-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix importlib-metadata on Python 3.8 + bump ale-py #2428
Conversation
I see you came across the same bug as I have in #2427. This might deserve an issue of its own, but now I understand even less how this happened just now. In any case, we'd need to decide on which solution to use. From what I see, you wrote some code to emulate |
Hey @RedTachyon, it happened just now as we just published a minor version of RE: the solution: I'd prefer that as well, the issue being |
@JesseFarebro Did the new version change the registration placement of some environments? I'm trying to make sense of what happened, whether something just messed up the tests externally and it so happens that we made PR's now, or did we both just make PR's that actually expose the underlying bug, and happened to do them roughly at the same time? In any case, to make sure I understand, you agree with using the "external" library |
The new release of
Sorry, I should have been more clear, I would like this solution but Perhaps we should catch these warnings as they may get pretty annoying for users on 3.7 as this occurs right when you import Gym. |
Is that really the case? I just made a clean conda installation of Python 3.7 with gym==0.20.0 and importlib-metadata-4.8.1 and get no warnings. |
Gym 0.20 didn't include the plugin system. Install gym from Edit: if you do what I said on Python 3.7 you'll see the warning as well. |
No description provided.